Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP 8.4 deprecations #444

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cedric-anne
Copy link
Contributor

Implicitly nullable parameter declarations are deprecated in PHP 8.4. The proposed change is safe and is not considered by PHP as a signature change, see https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

@yakatz
Copy link
Contributor

yakatz commented Sep 26, 2024

This can't pass the tests until PHP 8.4 is actually released, or it needs to specify the PHP version as 8.4-rc to use the beta version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants